simple-pid
simple-pid copied to clipboard
Improve tests
The test suite for this library could be improved. The biggest problem is that it's not completely deterministic, so sometimes tests can fail due to timing and pass if you just rerun it. It should be fixed so that you get the same result every time running a test. Possibly dt
and/or time_fn()
could help. Some care needs to be taken so that the tests still test what they intend to test though.
The tests also take a needlessly long time to run, mostly because of test_converge_system()
. It would be nice if this could be sped up.
I'm sure one could think of more tests to add too.