artiq icon indicating copy to clipboard operation
artiq copied to clipboard

Add channel name to RTIO errors

Open Deepskyhunter opened this issue 3 years ago • 0 comments

ARTIQ Pull Request

Description of Changes

Add channel name in the log message when having RTIO errors. The channel name is based on the name in device database

Two new methods in tools: device_map(): get device name by it's channel number from device database channel_address_map(): get address detail by accessing get_address_name() of the device driver class

Implement HasAddress for drivers that use rtio_output Driver with HasAddress should have a dictionary of address_map for mapping and static get_address_name() for accessing the map.

Related Issue #1697

Type of Changes

Type
:sparkles: New feature

Steps (Choose relevant, delete irrelevant before submitting)

All Pull Requests

  • [x] Use correct spelling and grammar.
  • [x] Close/update issues.

Code Changes

  • [x] Run flake8 to check code style (follow PEP-8 style). flake8 has issues with parsing Migen/gateware code, ignore as necessary.
  • [ ] Test your changes or have someone test them. Mention what was tested and how.

Git Logistics

  • [x] Split your contribution into logically separate changes (git rebase --interactive). Merge/squash/fixup commits that just fix or amend previous commits. Remove unintended changes & cleanup. See tutorial.
  • [x] Write short & meaningful commit messages. Review each commit for messages (git show). Format:
    topic: description. < 50 characters total.
    
    Longer description. < 70 characters per line
    

Licensing

See copyright & licensing for more info. ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.

Deepskyhunter avatar Jul 05 '22 04:07 Deepskyhunter