etl icon indicating copy to clipboard operation
etl copied to clipboard

Add capacity to filter select client_name values

Open stephen-soltesz opened this issue 2 years ago • 1 comments

This change adds support for filtering select client_name values from the ndt7 ClientMetadata. This change prevents the value from being published to BigQuery, making the value effectively unsearchable, though it will remain in the underlying raw storage. Since clients optionally provide the client_name value, it is impossible to distinguish between clients that never provided the value or those that have the value filtered without looking at the raw data directly.


This change is Reviewable

stephen-soltesz avatar Dec 13 '22 20:12 stephen-soltesz

Pull Request Test Coverage Report for Build 7433

  • 32 of 35 (91.43%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 67.384%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/ndt7_result.go 32 35 91.43%
<!-- Total: 32 35
Files with Coverage Reduction New Missed Lines %
active/active.go 2 90.63%
<!-- Total: 2
Totals Coverage Status
Change from base Build 7429: 0.2%
Covered Lines: 3351
Relevant Lines: 4973

💛 - Coveralls

coveralls avatar Dec 13 '22 20:12 coveralls

Obsolete.

stephen-soltesz avatar Dec 21 '22 01:12 stephen-soltesz