angular-dialog-service icon indicating copy to clipboard operation
angular-dialog-service copied to clipboard

Options object

Open dougmoscrop opened this issue 9 years ago • 1 comments
trafficstars

Let's refactor .create to take an options object.

I propose that since the current version takes URL as the first parameter, it's probably always true that arguments.length >= 1 and that arguments[0] is a string, therefore if arguments.length === 1 and arguments[0] is an object, they're using the proposed new style. I believe this should be backwards compatible.

Schedule:

  • [ ] Introduce the new option (5.3)
  • [ ] Deprecate the old style (5.4)
  • [ ] Remove the old style (6.0)

Thoughts?

dougmoscrop avatar Dec 10 '15 16:12 dougmoscrop

Sounds good! I would however introduce new option in next minor, then - deprecate in next next minor, then - remove in next major to stay semver

venil7 avatar Dec 10 '15 16:12 venil7