angular-dialog-service icon indicating copy to clipboard operation
angular-dialog-service copied to clipboard

Error, Notify and Wait dialogs don't close with ui-bootstrap-0.13.0

Open Luftzig opened this issue 10 years ago • 3 comments
trafficstars

I have been using angular-dialog-service with ui-bootstrap-0.12.1 successfully for sometime, but with ui-bootstrap-0.13.0 neither the close button, the X button, or clicking on the backdrop closes the dialogs. Custom dialogs with my own close logic do work (they call $modalInstance.close() ). Root cause is in the call to $scope.$destroy() in the default close functions which prevent afterAnimating callback in $modalStack from executing.

Luftzig avatar Jun 28 '15 08:06 Luftzig

Can you create a pull request for this. Also, I haven't been able to reproduce this issue with my site.. What version of angular are you using?

niemyjski avatar Jul 09 '15 14:07 niemyjski

https://github.com/m-e-conroy/angular-dialog-service/pull/121#issuecomment-116298872

niemyjski avatar Jul 09 '15 14:07 niemyjski

Is there any chance you could create a jsfiddle for this?

niemyjski avatar Jul 09 '15 14:07 niemyjski