vpn-webauth icon indicating copy to clipboard operation
vpn-webauth copied to clipboard
verified publisher icon m-barthelemy

Add Generic OAuth2 Provider Support

Open ethantmcgee opened this issue 3 years ago • 5 comments

ethantmcgee avatar Aug 12 '22 20:08 ethantmcgee

This pull request adds support for generic OAuth2 providers like Fusion Auth (https://fusionauth.io). I've also added a sample docker-compose.yml file to help with deploying the project more easily.

ethantmcgee avatar Aug 12 '22 20:08 ethantmcgee

I also fixed an issue where the OTP / OTC codes did not work in mobile safari (and added integrity hashes / nonces for security)

ethantmcgee avatar Aug 14 '22 18:08 ethantmcgee

Thanks for the PR! I'll review it but it might take me a few weeks in order to get the time to do it + test the result.

m-barthelemy avatar Aug 17 '22 14:08 m-barthelemy

@m-barthelemy I have reviewed all your comments and made the changes you requested. I've tested this using my local setup and all seems good on both desktop and mobile. There is one comment left unresolved. Please let me know how you want to proceed.

ethantmcgee avatar Sep 20 '22 04:09 ethantmcgee

@m-barthelemy I have reviewed all your comments and made the changes you requested. I've tested this using my local setup and all seems good on both desktop and mobile. There is one comment left unresolved. Please let me know how you want to proceed.

Thanks a lot!! Give me while to go through your work again.

m-barthelemy avatar Sep 21 '22 10:09 m-barthelemy