media-autobuild_suite
media-autobuild_suite copied to clipboard
m-ab-s
Some audio tools always get built, no INI switches included
Apparently there are no INI/CLI options to disable building of:
- vorbis-tools
- opus, opusfile, libopusenc, opus-tools
- lame 3.100
so they are always checked for updates even when you try to set up MABS so that only one single tool gets built.
vorbis-tools
if [[ $standalone = y ]] && enabled libvorbis &&
do_vcs "https://github.com/xiph/vorbis-tools.git"; then
seems it's conditioned on if you want to build standalone binaries and if you have libvorbis enabled, even if you have ffmpeg disabled. I can try changing that to
if [[ $standalone = y ]] && [[ $ffmpeg != no ]] && enabled libvorbis &&
do_vcs "https://github.com/xiph/vorbis-tools.git"; then
so that it will only be built if you were intending for libvorbis to also be enabled for ffmpeg (currently libvorbis itself is provided by msys2's package)
Actually, a lot of them are just enabled lib without checking for if ffmpeg is enabled (I don't know which ones mpv check for), I will just go ahead and add the ffmpeg check in for those
Actually, I realized that I can just move the [[ $ffmpeg != no ]] check to inside enabled() and that would probably fix it all, but I am concerned about potential issues, but we can hopefully fix those as we find them
Hope that the changes wont disable the build of these tools in question even though ffmpeg is not selected to be built. An option to build or not to build would be the best solution.
Personally so do I utilize all 3 of the tools that LigH-de mentioned in the 1st post.
The dilemma will be that some may want to link libraries into ffmpeg but not build separate executables; some may want to build separate executables instead but not ffmpeg.
I wanted to build nothing but uvg266, here I did not need any audio codec.
@1480c1 would it possible for you to 'just' add ini-switches for the tools in question. It would be the best solution imo.