lyz-code
fix: Support maison 2.0.0
Closes #258
I didn't see a good way to test both alternatives directly in the test suite, and it seemed too aggressive to just require the new version (though I can do that if you prefer). However, I've at least tested manually with both old and new versions of maison.
Pull Request Test Coverage Report for Build 10568469741
Details
- 8 of 9 (88.89%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-0.2%) to 95.588%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| src/autoimport/entrypoints/cli.py | 8 | 9 | 88.89% |
| <!-- | Total: | 8 | 9 |
| Totals | |
|---|---|
| Change from base Build 9895668044: | -0.2% |
| Covered Lines: | 325 |
| Relevant Lines: | 340 |
💛 - Coveralls
Thank you for your contribution @cjwatson , the path we've followed at yamlfix is to release a last version with the version pinned for maison < 2.0.0 and then assume that the users using the latest version are going to use the latest version of the dependencies.
If that sounds good to you, the ideal path for me would be:
- Do a pr to pin the versions, we'll merge it and I release a patch version
- Then tweak this pr to only support maison > 2.0.0 (increasing the version pin in
pyproject.toml), once merged I'll do a minor release.
How do you see it?
@zhou13 's contribution to pin maison <2.0.0 is merged and released at 1.6.1.