base62 icon indicating copy to clipboard operation
base62 copied to clipboard

tests are failing, things are broken

Open ds0nt opened this issue 7 years ago • 4 comments

Hey lytics. Nice project you have here. I'm using it in something for work. Unfortunately the latest merge here has broken tests. If you run go test . at this projects root you will see that the latest commit broke things with the ? string somehow.

commit 2c06157bd55d0d09bb15e7648606e065a8a5079f has passing tests, so I am pinning to that commit for the time being.

the latest commit: 6146185d8a0363f33780de1629e292efcd12d2cd doesn't have passing tests, and in my project's tests that depend on this, it runs into out of bounds errors

You should probably look into automating the CI, so that you don't break your test :)

ds0nt avatar Jan 22 '18 08:01 ds0nt

i took a glance at the diff, and didn't know how that could make it run into out of bounds errors. Hmm.

ds0nt avatar Jan 22 '18 08:01 ds0nt

check here for a .travis.yml I just made in a fork

https://github.com/ds0nt/base62/blob/master/.travis.yml

ds0nt avatar Jan 22 '18 11:01 ds0nt

just pushed up some fixes, travis etc

araddon avatar Jan 22 '18 17:01 araddon

Here is a working library if you are interested: https://github.com/nicksnyder/base62

nicksnyder avatar Apr 18 '19 06:04 nicksnyder