Jaka Kranjc

Results 694 comments of Jaka Kranjc

Some may not cause a window change.

There's no need for a setting — if other games don't have window open/close sounds, those entries will just be empty. Currently it's unset only in pst and even there...

Nothing useful on the why in the commit message: c571c2297d. Perhaps for GUISTORE switching, since two windows are involved? If a game doesn't use them at all, we can just...

One of your initial messages is still unclear — how do other games behave? It's something that's easier to test with let's say opening the journal or inventory.

I disagree, we should just detect it. It's simple to test.

I think three path groups will be enough. One for our files, one for game files and one for saves (more likely to be stored on a different partition, especially...

The reason for not using a runner is that they don't provide ARM hardware for mac and that brew can't be used to crosscompile.

Of course, but you need one or the other to make a build.

No. :) Was just saying that you either need the hardware to compile on natively or all the software to enable crosscompiling.

Btw, cmake does support signing, just not sure if also with the makefile generator. There's also the bundle generator for cpack (which we don't use) that also does signing: https://cmake.org/cmake/help/git-stage/cpack_gen/bundle.html#...