redux-auth icon indicating copy to clipboard operation
redux-auth copied to clipboard

React Warning

Open eseQ opened this issue 8 years ago • 4 comments

Hello.

Use material-ui and I have 2 warnings:

  1. Unknown prop errors on tag. Remove this prop from the element. https://fb.me/react-unknown-prop

  2. value prop on input should not be null. For example

const value = undefined;
return <input type="text" value={value}/>; // <-------- bad (uncontrolled)
const value = undefined;
return <input type="text" value={value || ''}/>; // <-------- good (controlled)

How i can fix that?

eseQ avatar Dec 29 '16 08:12 eseQ

Same here on a simple EmailSignUpForm 😓

yogsky avatar Dec 29 '16 15:12 yogsky

Upgrading react-bootstrap dependency version from ^0.29.5 to the most recent one (0.30.7 at the moment) should fix the issue, as this has been fixed in version 0.30.1: https://github.com/react-bootstrap/react-bootstrap/pull/2095 I am totally new to Redux and all, but I could try and do a PR.

tizub avatar Jan 12 '17 20:01 tizub

@lynndylanhurley @tizub Would love to see this resolved. Thank you for all your hard work guys!

michaelcjoseph avatar Feb 01 '17 22:02 michaelcjoseph

I have same problem.

Maybe, warning 1 is caused by this line.

  • https://github.com/lynndylanhurley/redux-auth/blob/master/src/views/default/Input.js#L51

{…this.props} extracts all of AuthInput props here, but <input /> element has no errors prop.

@tizub Probably, it will not work with react-bootstrap v0.30.x because <Input /> has been removed in v0.30.0 😢

nukosuke avatar Feb 09 '17 08:02 nukosuke