redux-auth icon indicating copy to clipboard operation
redux-auth copied to clipboard

Confirmation Success Url

Open jclif opened this issue 8 years ago • 9 comments

Howdy!

I'm experiencing some issues with the confirmation flow. When I try to sign in as a new user, I am redirected back to the signup page but my app is throwing an error that I don't recognize. Has anyone encountered this particular issue?

Should I be setting the confirm_success_url within settings when I call configure?

The error I'm seeing is: TypeError: Cannot read property 'replace' of undefined

signup_error

jclif avatar Aug 27 '16 05:08 jclif

I believe this might be related to #77.

jclif avatar Aug 28 '16 04:08 jclif

@lynndylanhurley From what I can tell, the line:

value.replace(/[^+#$&/:<-\[\]-}]/g, encodeURIComponent)

fails when the variable called name is a string 'authHeaders' because value is undefined.

jclif avatar Aug 28 '16 04:08 jclif

it looks like the same problem as mine. Did you have this problem when trying to reset the password as well?

betoharres avatar Aug 29 '16 20:08 betoharres

Please set the config.action_mailer.default_url_options = { :host => 'https://localhost:3000' } in Rails application at development.rb

vijaychouhan-rails avatar Sep 16 '16 03:09 vijaychouhan-rails

@vijaychouhan-rails I believe the rails server has the correct email url; it links me to my front-end application correctly.

jclif avatar Sep 16 '16 03:09 jclif

@betoharres Yes, this happens on password change as well. What has been your solution to this? We would like to use this library for auth, but we are stuck because of these issues.

jclif avatar Sep 24 '16 16:09 jclif

@jclif Yeah, I did a PR 10 days ago fixing these problems, you can check it out my solution here, but it was not merged. I'm using this lib locally with my modifications. But the thing is: if you clone this repo right now in the master branch and run it's tests, it will show all green even with all these errors. When I fixed, I broke 24 tests but I fixed the problem and everything else works the same. If you know anything about the tests used in this lib, please help us out, it will be very welcome ❤️

betoharres avatar Sep 26 '16 14:09 betoharres

@betoharres Interestingly, when I run these tests locally, they appear to pass without any problems.

jclif avatar Sep 27 '16 14:09 jclif

@jclif They do, that's the problem! haha

betoharres avatar Sep 27 '16 20:09 betoharres