lynndylanhurley
Allow backup field authorization for login & password reset
Resolves: #509 Replaces: #510
Notes:
- Read commits in order
- Changes allow for polymorphic relationships
- PR will be followed up with a modification to the registrations controller (to allow polymorphic relation construction)
- viewable at https://github.com/djsegal/devise_token_auth/pull/1
Will try to take a look at this in the next couple of days @djsegal.
@lynndylanhurley / @nbrustein - could probably use some more eyes on this one!
Afraid I've been swamped @djsegal. Will try to take a look at it ASAP unless @lynndylanhurley beats me to it.
@booleanbetrayal any word on this? I can look into doing a rebase if you think it's worth it.
Hi there @djsegal ,
In an effort to cleanup this project and prioritize a bit, we're marking pull requests that haven't had any activity in a while with a "close-in-7-days" label. If we don't hear from you in about a week, we'll be closing this pull request. Obviously feel free to re-open it at any time if it's the right time or this was done in error! If you do, please rebase it with the latest master and explain why it's still needed.
We really appreciate your contribution, we're just trying to make this project manageable again to move it forward.
Hope all is well.
@djsegal I apologize for the delay. Re-opening now, I'll look into this ASAP
@resource = q.find_by(provider: 'email')
Strongly recommend against any refactorings that presume or hardcore provider to be 'email.' I believe this forced coupling is an immense source of unneeded complexity within this gem that makes things very hard to change for anyone who is trying to configure this gem for use cases outside of email (like usernames or phone numbers).
