lykos icon indicating copy to clipboard operation
lykos copied to clipboard

RFC: modify guardian_lose_with_guards win condition in guardian

Open bugmen0t opened this issue 5 years ago • 2 comments

Recent guardian game [~2010-12-20 23:00 UTC] had this rather surprising interaction: The day started with 3 wolves alive, 2 GA, and 1 vil alive. wolf gunner shoots and wounds one of GA, and gets lynched afterward. On their lynch, guardian_lose_with_guards gets triggered. Triggering wolf win condition on wolf lynch seems counterintuitive, so this patch seeks to alleviate that [lpl does not include absent players during the day, so that's why I chose this approach].

An alternate fix would be switching lwolves == lguardians to lwolves >= lguardians so wolves would get their win when GA was shot, not sure what was an intention here.

bugmen0t avatar Dec 21 '20 10:12 bugmen0t

Full game logs: https://0bin.net/paste/VqiMXVUu#foW3PCl2Srn2dNtB6dsGqDic5MbyTkrNA4X2xIxch7d

bugmen0t avatar Dec 21 '20 11:12 bugmen0t

The point of the absent status is that those people are counted as not in the village for all win condition checking. It should probably be >= instead of == though so it ended earlier. Also lguardians should exclude absent GAs which it currently isn't doing.

skizzerz avatar Dec 25 '20 05:12 skizzerz