Yonggang Luo comments

Results 216 comments of


                                            Yonggang Luo

trafficstars

Virgil 3D with SDL2 on macOS

Maybe it's should be ``` if ((window->flags & SDL_WINDOW_FULLSCREEN_DESKTOP) == SDL_WINDOW_FULLSCREEN_DESKTOP) { ``` I am confusing about the change.

We may add a option: "git-graph.useVscodeEncoding": true, then "git-graph.fileEncoding" are disabled. when git-graph.fileEncoding is not specified, auto using files.encoding and files.autoGuessEncoding

improvement file encoding

By using https://github.com/microsoft/vscode/issues/824

cross compile arm buildKitTargetArch is unknown

> Right now, the extension does not query the compiler for supported cross-compile targets. The command is essentially `gcc -v`. I believe this only reports the host triplet. @lygstate, I...

Feature request, better debugger intergration with QT

> Thank you for the feature idea. We will analyze and triage it. In the mean time, since I am not very familiar with this, just give a few more...

Revise implementation of jerry_port_get_local_time_zone_adjustment on Win32

> I'm still not really happy about `long long`s, such inconsistency just itches me. The rest looks OK with me -- in general. But the details of computations should be...

Revise implementation of jerry_port_get_local_time_zone_adjustment on Win32

ping for review or merge

Revise implementation of jerry_port_get_local_time_zone_adjustment on Win32

any progress?

Fixes unit-test-date-helpers failure on win32

@zherczeg This can be merged directly

Question, why ecma_create_error_reference are needed, as error are also an object.

> The simple reason is that the current API's error handling differs from the internal. Internally only 1 pedinding expection is allowed. These execptions are transformed into error_references, which "saves"...