toasted-marshmallow icon indicating copy to clipboard operation
toasted-marshmallow copied to clipboard

Integration with latest marshmallow (3.6.1)

Open tschaume opened this issue 4 years ago • 5 comments

An attempt to make progress on #16. pytest currently fails with

AttributeError: 'TestSchema' object has no attribute '_marshal'

patrick_Patricks-MBP____gitrepos_mp_MPContribs_mpcontribs-api_toasted-marshmallow

tschaume avatar Jun 18 '20 22:06 tschaume

Hi ! Thanks for the effort @tschaume. Unfortunatly the merge is blocked for 2 years now, is there any possible action to fix the automated test ?

tramora avatar Jun 02 '22 10:06 tramora

@tramora I tried to make as much progress as I could back then and left this PR in case a maintainer would have the bandwidth to help me move this forward. I never ended up using toasted-marshmallow since I was under the impression that the speed-up wasn't as significant anymore with marshmallow3 🤷

tschaume avatar Jun 02 '22 19:06 tschaume

@tramora I tried to make as much progress as I could back then and left this PR in case a maintainer would have the bandwidth to help me move this forward. I never ended up using toasted-marshmallow since I was under the impression that the speed-up wasn't as significant anymore with marshmallow3 🤷

@tschaume do you have any docs/reference for this "the speed-up wasn't as significant anymore with marshmallow3 🤷" ?

PavanTatikonda avatar Jul 13 '22 16:07 PavanTatikonda

@PavanTatikonda I unfortunately can't remember where I read it 😞 Maybe it was just an overall impression from reading the changelogs: https://marshmallow.readthedocs.io/en/stable/changelog.html#rc9-2019-07-31

tschaume avatar Aug 18 '22 23:08 tschaume

If anyone stumbles upon this issue hoping to get Toasted working with latest Marshmallow versions, I've created a fork of the project that works with all latest Marshmallow versions (3.13 and up), and does not require Marshmallow to be forked and modified. You can find it here: https://github.com/mLupine/DeepFriedMarshmallow

mLupine avatar Oct 04 '23 21:10 mLupine