toasted-marshmallow
toasted-marshmallow copied to clipboard
Integration with latest marshmallow (3.6.1)
An attempt to make progress on #16. pytest
currently fails with
AttributeError: 'TestSchema' object has no attribute '_marshal'
Hi ! Thanks for the effort @tschaume. Unfortunatly the merge is blocked for 2 years now, is there any possible action to fix the automated test ?
@tramora I tried to make as much progress as I could back then and left this PR in case a maintainer would have the bandwidth to help me move this forward. I never ended up using toasted-marshmallow
since I was under the impression that the speed-up wasn't as significant anymore with marshmallow3 🤷
@tramora I tried to make as much progress as I could back then and left this PR in case a maintainer would have the bandwidth to help me move this forward. I never ended up using
toasted-marshmallow
since I was under the impression that the speed-up wasn't as significant anymore with marshmallow3 🤷
@tschaume do you have any docs/reference for this "the speed-up wasn't as significant anymore with marshmallow3 🤷" ?
@PavanTatikonda I unfortunately can't remember where I read it 😞 Maybe it was just an overall impression from reading the changelogs: https://marshmallow.readthedocs.io/en/stable/changelog.html#rc9-2019-07-31
If anyone stumbles upon this issue hoping to get Toasted working with latest Marshmallow versions, I've created a fork of the project that works with all latest Marshmallow versions (3.13 and up), and does not require Marshmallow to be forked and modified. You can find it here: https://github.com/mLupine/DeepFriedMarshmallow