ModuleSyncMetadata breaks for Okta trial

[danielsaporo]

I am checking out Cartography with an Okta trial. So, my Okta account looks like trial-xxxxxxx.

When Okta finishes sync'ing, I get the following error in util.py:

{code: Neo.ClientError.Statement.SyntaxError} {message: Variable trial not defined (line 7, column 23 (offset: 277)) " n.groupid=trial-xxxxxxx,"

That's because the dash in the groupid breaks the syntax. To fix it, it's enough to surround the parameter with single quotes.

Note: the actual code I'm using is a little different since I've modified the Cypher queries to work with Neo4j 4.4, but you should be able to reproduce this on the current Cartography codebase.

[ramonpetgrave64]

Thanks for the find. Can you submit a PR?

[achantavy]

Is this issue still valid now that we are completely on Neo4j 4.x? If so, we'd love a PR from anyone to help out, looks like it'd be fairly quick to do.

[danielsaporo]

@achantavy From my end I don't have access to a trial any more (it expired) so I can neither answer the question nor test a potential fix before submitting it. If someone else could check this quickly, it would be great.