cartography
cartography copied to clipboard
Extension of support for current GCP & Azure services
For GCP, support for these additional services - IAM, API Gateway, Cloud KMS, Cloudrun, GCP SQL, Firestore, Bigtable, Cloud Function
For Azure, support for these additional services - Function App, Network, Resource Group, Tag, IAM, Key Vaults, AKS
@kedarghule @achantavy We messed up with our commits on our fork. So, we ended up with such a huge PR. Can you guys please review the changes?
Note: We are fixing the unit test issues on our end.
@mpurusottamc Thank you so much! This is a massive PR, indeed. And all of us contributors will need some time to review it. For now, it would definitely help to have the Azure and GCP additions in separate PRs, and to exclude some of the formatting changes.
I'll take a look but this will take time. I'll start by looking at the Azure components first.
Much appreciate the contribution, but this is really huge to review. Like what @ramonpetgrave64 said, would you be able to please split it out to smaller chunks?
It might be most straightforward to copy paste things out of this PR into other separate PRs, but I'm also not a git expert so there might be a smarter way :)
Hi @achantavy @kedarghule @ramonpetgrave64 , We are in the process of creating a separate PRs for GCP, Azure and AWS.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Hi @achantavy @kedarghule @ramonpetgrave64 , We are in the process of creating a separate PRs for GCP, Azure and AWS.
Hi @ajinkya1986 @mpurusottamc , any update on this?
@marco-lancini We are working on it and will open a PR early next week
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.