cartography icon indicating copy to clipboard operation
cartography copied to clipboard

Extension of support for current GCP & Azure services

Open mpurusottamc opened this issue 3 years ago • 10 comments

For GCP, support for these additional services - IAM, API Gateway, Cloud KMS, Cloudrun, GCP SQL, Firestore, Bigtable, Cloud Function

For Azure, support for these additional services - Function App, Network, Resource Group, Tag, IAM, Key Vaults, AKS

mpurusottamc avatar Feb 13 '22 21:02 mpurusottamc

@kedarghule @achantavy We messed up with our commits on our fork. So, we ended up with such a huge PR. Can you guys please review the changes?

Note: We are fixing the unit test issues on our end.

mpurusottamc avatar Feb 14 '22 05:02 mpurusottamc

@mpurusottamc Thank you so much! This is a massive PR, indeed. And all of us contributors will need some time to review it. For now, it would definitely help to have the Azure and GCP additions in separate PRs, and to exclude some of the formatting changes.

ramonpetgrave64 avatar Feb 15 '22 15:02 ramonpetgrave64

I'll take a look but this will take time. I'll start by looking at the Azure components first.

kedarghule avatar Feb 20 '22 22:02 kedarghule

Much appreciate the contribution, but this is really huge to review. Like what @ramonpetgrave64 said, would you be able to please split it out to smaller chunks?

achantavy avatar Feb 24 '22 01:02 achantavy

It might be most straightforward to copy paste things out of this PR into other separate PRs, but I'm also not a git expert so there might be a smarter way :)

achantavy avatar Feb 24 '22 01:02 achantavy

Hi @achantavy @kedarghule @ramonpetgrave64 , We are in the process of creating a separate PRs for GCP, Azure and AWS.

ajinkya1986 avatar Mar 03 '22 09:03 ajinkya1986

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Apr 16 '22 23:04 stale[bot]

Hi @achantavy @kedarghule @ramonpetgrave64 , We are in the process of creating a separate PRs for GCP, Azure and AWS.

Hi @ajinkya1986 @mpurusottamc , any update on this?

marco-lancini avatar Apr 21 '22 20:04 marco-lancini

@marco-lancini We are working on it and will open a PR early next week

ajinkya1986 avatar Apr 22 '22 04:04 ajinkya1986

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Sep 21 '22 08:09 stale[bot]