cartography icon indicating copy to clipboard operation
cartography copied to clipboard

fix(pagerduty): migrate from deprecated pdpyras to pagerduty package (#1837)

Open leaf5135 opened this issue 4 months ago • 2 comments

Summary

This PR migrates the PagerDuty integration from the deprecated pdpyras package to the new supported pagerduty package. It updates dependencies and refactors code to use the new API. This change resolves deprecation warnings and ensures long-term support and compatibility.

image image

Related issues or links


Checklist

Provide proof that this works (this makes reviews move faster). Please perform one or more of the following:

  • [ ] Update/add unit or integration tests.
  • [ ] Include a screenshot showing what the graph looked like before and after your changes.
  • [x] Include console log trace showing what happened before and after your changes.

If you are changing a node or relationship:

  • [ ] Update the [schema](https://github.com/cartography-cncf/cartography/tree/master/docs/root/modules) and [readme](https://github.com/cartography-cncf/cartography/blob/master/docs/schema/README.md).

If you are implementing a new intel module:

  • [ ] Use the NodeSchema [data model](https://cartography-cncf.github.io/cartography/dev/writing-intel-modules.html#defining-a-node).

leaf5135 avatar Aug 24 '25 08:08 leaf5135

Hey @leaf5135 thanks for taking this on! Just wondering, have you tried this on PD yet? If not that's ok, I can try manually test later

achantavy avatar Aug 28 '25 03:08 achantavy

@achantavy Not yet — feel free to run it on your end in PD

leaf5135 avatar Aug 28 '25 07:08 leaf5135