lyef-react-component icon indicating copy to clipboard operation
lyef-react-component copied to clipboard

How to deal with css

Open willianjusten opened this issue 9 years ago • 4 comments

Should be normal with import by anothers? Should be inline with Aphrodite/Radium/CssModules or anything else?

willianjusten avatar Jul 23 '16 02:07 willianjusten

@Nipher

willianjusten avatar Jul 23 '16 02:07 willianjusten

@willianjusten I really like the first option.

Because it's easy than others developers - that never wrote css inline via javascript - to adapt to the ecosystem with ease. It's more fluid.

Of course, given the choice, we must do some things related to tests...

I think a relevant discussion 👍

caueops avatar Jul 24 '16 17:07 caueops

@willianjusten I think that it would be awesome to have a basic style when using these independents components on the application layer.... BUT it must be very easy to override it when wanted to, imo...

I don't know which is the best approach here, you mentioned some approaches that I don't know much about, I'll try to give a deeper look at this subject to have a stronger opinion

jmpas avatar Jul 24 '16 18:07 jmpas

I was looking to the new Airbnb's project and they did a very nice way to handle with theming and css. React Dates Theming.

Maybe we can use something similar... What you think @Nipher ?

willianjusten avatar Aug 29 '16 21:08 willianjusten