Lanqing Yang

> Are you able to share a minimal reproducible example? not yet sorry i am not that skilled in rust. but if h2 will throws an error with reason::cancel and...

> Hyper errors have h2 errors as the ["source"](https://doc.rust-lang.org/stable/std/error/trait.Error.html#method.source) which should get picked up by tonic. At least I remember doing a bunch of testing around that last time we...

@davidpdrsn yep you are right hyper have h2 error as source. i have a quick question should we handle h2 error here since we are polling from the stream? i...

updated desc reopen and will work towards an example tmr

Hi which linux version are you running with? and can you please share the command to repro?

I digged more into the test failure with @pav-kv, we added prints to mvccput and found the orginal value being put is a SimpleMVCCValue ``` key: /Local/RangeID/68/r/RangeGCThreshold value: [7a 00...

Previous thread is resolved, I wrapped decoding logic under the `if mvccKey.IsValue()` just like [here](https://github.com/cockroachdb/cockroach/blob/4e4644352bb6bfdd7b4045e2a5dbbb89d3f68dfa/pkg/storage/verifying_iterator.go#L35-L58) test passes, I guess mvcckey without a timestamp is another category of mvccdata. ``` if...

*[`pkg/kv/kvserver/store_snapshot.go` line 555 at r7](https://reviewable.io/reviews/cockroachdb/cockroach/119345#gh-1523304554:-Ntrjh16AdZ9Rb9oVLEZ:bhr5vh9) ([raw file](https://github.com/cockroachdb/cockroach/blob/4140eb971e6f283ed8edb6576ae27d6273895f6c/pkg/kv/kvserver/store_snapshot.go#L555)):* Previously, pav-kv (Pavel Kalinnikov) wrote… A bunch of func calls below (e.g. `PutInternalRangeKey`) will decode the `EngineKey` internally. I wonder if the APIs...

unfortunately this pr experienced the same test failures will wait for the fix of 121342 then rebase and merge https://github.com/cockroachdb/cockroach/issues/121342

bors r+