Guennadi Liakhovetski

Results 122 comments of Guennadi Liakhovetski

> We can see driver sends SOF_IPC4_PIPE_RESET and the mixin_mixout component erases state in its mixout_reset. @kv2019i https://github.com/thesofproject/sof/pull/6414/commits/eb521650fdfe838b0c92014a11d9834b93b69dd0 should fix it, waiting for CI...

> > @kv2019i [eb52165](https://github.com/thesofproject/sof/commit/eb521650fdfe838b0c92014a11d9834b93b69dd0) should fix it, waiting for CI... > > @lyakh , that added memset() inside mixout_bind() will create problems: mixout can be connected to multiple mixins so...

> @plbossart AMS is basically notifications on steroids. It allows broadcasting notifications from one producer to multiple consumers, as well as targeting single consumers. Producers/consumers can be registered runtime. It...

Now you can also see sparse complaints about address space violations https://github.com/thesofproject/sof/actions/runs/3282088398/jobs/5405006166#step:4:5259 : ``` /zep_workspace/sof/src/lib/ams.c:60:38: warning: incorrect type in argument 1 (different address spaces) /zep_workspace/sof/src/lib/ams.c:60:38: expected void const *m1 /zep_workspace/sof/src/lib/ams.c:60:38:...

@dbaluta sure, let's move it to a different location from prj.conf

@dbaluta https://github.com/zephyrproject-rtos/zephyr/pull/43687

> @lyakh ping. @lgirdwood as you see above, I proposed a fix, but it isn't perfect. I asked for better ideas but haven't got any suggestions so far.

BTW, we already managed to accumulate 14 sparse warnings as can be seen in this PR despite the sparse green status: ``` /zep_workspace/sof/src/audio/module_adapter/module/volume/volume_generic.c:59:61: warning: incorrect type in initializer (different address...

> @lyakh https://github.com/thesofproject/sof/actions/runs/3221338104/jobs/5269150847 prints hundreds if not thousands of warnings, always has. I'm guessing `(different address spaces)` is what makes these more important? > > As found in #6311 and...

> Thanks @lyakh for filing this! Some questions: > > 1. Is using sparse from git + the west build command you gave enough to run sparse on Zephyr now?...