terracotta icon indicating copy to clipboard operation
terracotta copied to clipboard

Published 20 hours ago • verified publisher icon lxsmnsyc

utilize dynamic dependencies

Open thetarnav opened this issue 1 year ago • 4 comments

Why not utilize dynamic dependencies here?

thetarnav avatar Sep 20 '22 20:09 thetarnav

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
solid-headless ❌ Failed (Inspect) Sep 20, 2022 at 8:19PM (UTC)

vercel[bot] avatar Sep 20 '22 20:09 vercel[bot]

The old code is that way however due to boolean short-circuit the latter code doesn't get tracked. That's the reason why I had to expand it into variable reads. Thanks for the PR but closing this.

lxsmnsyc avatar Sep 21 '22 03:09 lxsmnsyc

I know that it doesn't get tracked. That's the point 😉 Why track a signal which updates won't case a change? The first signal has to return false for the second to even matter. But yeah, it's not that important, just found that curious while looking through the code 😛

thetarnav avatar Sep 21 '22 07:09 thetarnav

Revisiting the concept, you might be right. I'll re-open this for now since the changed code is just one of the many same occurrences that I have changed in my local branch.

lxsmnsyc avatar Sep 21 '22 08:09 lxsmnsyc