lxqt-session icon indicating copy to clipboard operation
lxqt-session copied to clipboard

Removed display of broken option

Open stefonarch opened this issue 10 months ago • 10 comments

Maybe there is more to clean up after.

stefonarch avatar Jan 24 '25 10:01 stefonarch

I don't understand why but running it it activates ~screensaver~ screenlocker also if unchecked at suspend.

stefonarch avatar Jan 25 '25 19:01 stefonarch

I didn't understand what you meant. What's unchecked? Which screensaver? Where?

tsujan avatar Jan 26 '25 09:01 tsujan

I compiled that and forgot about after checking help and manpage, when I switched to Hyprland the screenlocker was activated on suspend without that this option was checked. Tested labwc and found the same, reinstalled lxqt-session master and all fine again.

stefonarch avatar Jan 26 '25 12:01 stefonarch

Oh, you changed the code too; I didn't see that. With the removal of app.setConfigName(parser.value(config_opt)); the method SessionApplication::setConfigName isn't called anymore, and so, session.conf isn't read. You should replace that line with:

    app.setConfigName();

However, I think it's better to fix that option, instead of removing it. Sadly, I don't remember what its problem was.

tsujan avatar Jan 26 '25 12:01 tsujan

Now I remember at least one of the problems: other LXQt config apps assume that the config file is session.conf.

If we want to remove this unused option, we should also change the code a little, because SessionApplication::setConfigName will have no job.

tsujan avatar Jan 26 '25 12:01 tsujan

That's the reason. I remember I got an compile error about that line. I don't know if there would be an easy way to tell all other apps to read an alternate config file (a value in session.conf session-config-file= ?) and it would need code changes in all of them afaik. Nobody will edit startlxqt, it could be eventually used in compositor autostart settings but I see no benefit to it.

stefonarch avatar Jan 26 '25 14:01 stefonarch

if there would be an easy way to tell all other apps to read an alternate config file…

There isn't :(

A suggestion: Keeping the option but adding a warning that it isn't compatible with some LXQt configuration tools.

tsujan avatar Jan 26 '25 14:01 tsujan

Why keeping an non-working option...

stefonarch avatar Jan 26 '25 14:01 stefonarch

In an imaginary world, someone may want to use LXQt Session with that option and without LXQt config tools.

tsujan avatar Jan 26 '25 15:01 tsujan

With a probability hard al limit del measurable yes.

stefonarch avatar Jan 26 '25 16:01 stefonarch