lxqt-session icon indicating copy to clipboard operation
lxqt-session copied to clipboard

-c option not working for lxqt-session

Open stefonarch opened this issue 2 years ago • 2 comments

I noticed that while testing a different config file under wayland, with lxqt-session -c /home/stef/.config/lxqt-wayland/session.conf.

  • lxqt-config-session writes to ~/.config/lxqt/session.conf
  • lxqt-session process crashes because lock_screen_before_power_actions=false is true (default) even if none of the both config files have set "true" (see https://github.com/lxqt/lxqt-session/issues/457)
Expected Behavior

-c option works, write and read

Current Behavior

It doesn't

Steps to Reproduce (for bugs)
  1. Use a different location, restart session
  2. Change some setting and look at the timestamps or settings in both session.conf
Context
System Information
  • Distribution & Version: arch, git

stefonarch avatar Mar 12 '23 06:03 stefonarch

Yes, there are three problems in the -c option:

  1. The function SessionApplication::setConfigName() doesn't read its argument (such mistakes happen when a variable name is used for the argument name).
  2. Even if the above-mentioned issue is fixed, the other parts of the code will ignore it. For example, the settings won't be written to the config file specified by the -c option.
  3. The environment variable LXQT_SESSION_CONFIG set by that function will be seen by LXQt::PowerManager::PowerManager() as a config name, not a path.

tsujan avatar Mar 12 '23 13:03 tsujan

We could just remove the -c option in `lxqt-session --help'.

stefonarch avatar Feb 26 '24 17:02 stefonarch