Review liblxqt/lxqtpower

[jleclanche]

Now that we switched to Solid, we can get rid of it, right?

[palinek]

It's been still referenced:

$ egrep -r '\s*#\s*include\s*["<][^">]*(Power(Manager)?|lxqtpower(manager)?\.h)[">]'
lxqt-panel/plugin-mainmenu/lxqtmainmenu.cpp:#include <LXQt/PowerManager>
liblxqt/lxqtpower/lxqtpowerproviders.h:#include "lxqtpower.h"
liblxqt/lxqtpower/lxqtpower.cpp:#include "lxqtpower.h"
liblxqt/lxqtpowermanager.cpp:#include "lxqtpowermanager.h"
liblxqt/lxqtpowermanager.cpp:#include "lxqtpower/lxqtpower.h"
lxqt-powermanagement/config/powermanagementsettings.cpp:#include <LXQt/Power>
lxqt-powermanagement/config/helpers.cpp:#include <LXQt/Power>
lxqt-powermanagement/src/lidwatcher.h:#include <LXQt/Power>
lxqt-powermanagement/src/batterywatcher.cpp:#include <LXQt/Power>
lxqt-powermanagement/src/watcher.h:#include <LXQt/Power>
lxqt-runner/providers.cpp:#include <LXQt/PowerManager>
lxqt-runner/dialog.cpp:#include <LXQt/PowerManager>
lxqt-session/lxqt-leave/main.cpp:#include <LXQt/PowerManager>
lxqt-session/lxqt-leave/leavedialog.h:#include <LXQt/Power>

However they may be only remnants...

[luis-pereira]

We can (and will) switch to Solid. But it's not dead code, it's still being used.

[paulolieuthier]

AFAIK Solid can't execute power actions like shutdown or reboot, and doesn't know about things like the lid and screensaver.

[luis-pereira]

There's SolidPower Have to dig in it.

[paulolieuthier]

@luis-pereira that does look very interesting and useful, even though it only supports (AFAICS) systemd and hal.