lxqt-panel icon indicating copy to clipboard operation
lxqt-panel copied to clipboard

Right click issue on fancy menu items and left click in mainmenu items with niri

Open stefonarch opened this issue 1 year ago • 5 comments

The panel restarts in both conditions on niri but I don't find a backtrace file. Running the panel with WAYLAND_DEBUG=1 lxqt-panel 2> /tmp/niri-menu-panel.log I see

[2575265.632] {Display Queue} wl_display#1.error(wl_surface#76, 2, "xdg_popup was not created on the topmost popup")
wl_surface#76: error 2: xdg_popup was not created on the topmost popup
The Wayland connection experienced a fatal error: Protocol error

which makes me think of an issue in the panel itself, which only on niri leeds to a crash.

Expected Behavior
Current Behavior
Possible Solution
Steps to Reproduce (for bugs)
  1. Use niri as compositor
  2. Try to add a app to favorites in fancy menu or
  3. open any app with main menu
  4. Panel restarts (if a module)
Context

Testing https://github.com/lxqt/lxqt-wayland-session/pull/24

System Information
  • LXQt Version: git
  • Distribution & Version: arch

stefonarch avatar Sep 22 '24 08:09 stefonarch

The panel restarts in both conditions on niri but I don't find a backtrace file.

If there's no coredump file, then the panel's process is stopped somehow, without any crash.

which makes me think of an issue in the panel itself...

On the contrary, there's nothing about lxqt-panel in it.

tsujan avatar Sep 22 '24 09:09 tsujan

Searching for the error the first link: https://bugreports.qt.io/browse/QTBUG-67988

but widgets sometimes sets the parent as the toplevel instead of the menu you would think of as the parent

https://wayland-book.com/xdg-shell-in-depth/popups.html

stefonarch avatar Sep 22 '24 11:09 stefonarch

Searching for the error the first link:

And it shows that the problem is not in lxqt-panel. Since it happens only with niri, niri should be the culprit.

tsujan avatar Sep 22 '24 13:09 tsujan

Not niri itself but smithay then.

stefonarch avatar Sep 22 '24 13:09 stefonarch

Searching for the error the first link: https://bugreports.qt.io/browse/QTBUG-67988

Remove the menu-bar of FeatherPad or PCManFM-Qt or …, run it from a terminal, click its menu toolbar button to show its menu, open a sub-menu, and see the message in the terminal.

The last sentence is "Please fix the transient parent of the popup." It's nonsense; No one with an experience in Qt coding could say it.

tsujan avatar Sep 22 '24 13:09 tsujan

Isn't this fixed in niri?

tsujan avatar Oct 25 '24 11:10 tsujan

Closing because, whether it's fixed in niri or not, the problem can't be in lxqt-panel.

tsujan avatar Nov 15 '24 15:11 tsujan

Should open an issue in smithay about it probably.

stefonarch avatar Nov 15 '24 17:11 stefonarch

Investigating we have more issues here:

  1. bookmarks dialog in fancy menu
  2. directorymenu's submenus
  3. Pause idleness checks from icon in tray
  4. No submenus opening on the desktop window

1-3 restart the panel.

stefonarch avatar Nov 19 '24 07:11 stefonarch

Investigating we have more issues here:

We don't; niri does. Just a small correction ;)

tsujan avatar Nov 19 '24 07:11 tsujan

What about removing the niri support until these issues are fixed? They're too serious, IMO.

tsujan avatar Nov 19 '24 07:11 tsujan

I don't think we should remove it, it's all labeled experimental and 98% of our features are working. I think it will be fixed at some point.

We have also https://github.com/hyprwm/Hyprland/issues/7737#issuecomment-2466808116 in Hyprland and https://github.com/swaywm/sway/issues/8100 in sway.

Adding them to the table in the wiki if there is space left would be enough.

stefonarch avatar Nov 19 '24 07:11 stefonarch

Done https://github.com/lxqt/lxqt/wiki/ConfigWaylandSettings

stefonarch avatar Nov 19 '24 08:11 stefonarch

should be fixed once https://github.com/Smithay/smithay/pull/1591 is merged and niri is updated to this commit

cmeissl avatar Nov 19 '24 21:11 cmeissl

That was fast, nice!

stefonarch avatar Nov 20 '24 06:11 stefonarch