anatole
anatole copied to clipboard
Fix Sidebar Title Changing Margin Size Between Home Page and Others
I noticed the home page side bar was repositioning items slightly when I moved from the home page to others. I had trouble finding the issue but realized it was the title (sidebar__introduction-title). On the homepage it's a h1 object and on others it's a div. I assume this is for SEO.
Both the H1 and DIV have the same CSS and same class - and even though they have the same margin of 1em, something is causing their margins to be computed differently. (For me h1 is 24px and div is 16pix).
A workaround for this was to keep both in a div with the same class, however when it's the home page wrap the a element in a h1 element while still keeping the div. I made sure the CSS styling removes the h1 elements margin while existing within the div too.
This keeps the positioning of sidebar objects consistent between pages.
Issue related: https://github.com/lxndrblz/anatole/issues/486
Deploy Preview for anatole-demo ready!
Name | Link |
---|---|
Latest commit | 9494b59ceb5e2e5007624d7dac0d020ba5a7befb |
Latest deploy log | https://app.netlify.com/sites/anatole-demo/deploys/65b8ff5210dc500008d36000 |
Deploy Preview | https://deploy-preview-487--anatole-demo.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
Lighthouse |
1 paths audited Performance: 90 Accessibility: 88 Best Practices: 100 SEO: 92 PWA: - View the detailed breakdown and full score reports |
To edit notification comments on pull requests, go to your Netlify site configuration.
Quality Gate passed
Kudos, no new issues were introduced!
0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code