liferea icon indicating copy to clipboard operation
liferea copied to clipboard

"Mark all as read ?" warning dialog does not appear on middle-clicking a feed in the feeds list

Open nekohayo opened this issue 8 months ago • 1 comments

Version

1.15.7 (unfortunately that's what Fedora 41 provides me, but I checked the changelog and there doesn't seem to have been a commit specifically about this since that release).

Problematic Behavior

There is no guardrail against accidental middle-clicks in the feeds list.

Steps to Reproduce

  1. Right-click a feed, "Mark all as read": you will get a confirmation dialog (as per #32):

Image

  1. Click Cancel

  2. Middle-click the feed in the feeds list, instead. All its items get marked as read with no warning.

Expected Behavior

Show the same dialog.

nekohayo avatar Mar 15 '25 16:03 nekohayo

Yep, there are currently 2 inconsistent mark-all-read code paths.

lwindolf avatar Mar 18 '25 19:03 lwindolf

Fixed by routing all code paths through the same action handler.

lwindolf avatar Aug 25 '25 15:08 lwindolf