liferea icon indicating copy to clipboard operation
liferea copied to clipboard

Revision signature in About

Open bbhtt opened this issue 2 years ago • 3 comments

Not very familiar with autoconf/automake but the idea should work. I've tried to keep it very simple.

Note.

  • The version string now needs to be only updated in .version. The tarball will be named liferea-v$version if from a tag or liferea-$sha-$date if from commit.
  • I don't know it is preferred to keep the "v" in version or not.
  • I haven't checked inside a tarball but it should just work.
  • This needs backported to 1.14 branch if merged with a different .version file.

Fixes https://github.com/lwindolf/liferea/issues/1258

Images

From the current HEAD git commit that does not belong to a tag:

5986e03ddb

From a checked out tag https://github.com/bbhtt/liferea/releases/tag/v1.110.819:

cfd58e2868

bbhtt avatar Oct 24 '23 06:10 bbhtt

The issue is intlool-update doesn't support m4_esyscmd_s but does m4_esyscmd. I wanted to use the latter to avoid newlines. I guess I'll add stripping instead.

bbhtt avatar Oct 24 '23 06:10 bbhtt

Sorry for taking so long to review.

I'm very unsure whether the solution would work well, as I cannot predict the build enviroment of package maintainers. They more or less rely on configure.ac to statically provide a version. And we cannot predict wether they'll build from a git checkout or using a fresh source directory (make dist).

lwindolf avatar Jan 14 '24 14:01 lwindolf

In case it is not from git, it reads the first line of the .version file using head.

Instead of the static version in configure.ac it will be now in .version. The version file will be included in tarballs when make dist is run.

Here is a tarball produced from source using make dist https://github.com/bbhtt/liferea/releases/download/v1.110.819/liferea-v1.15.4.tar.gz

I don't think that will be an issue?

bbhtt avatar Jan 14 '24 14:01 bbhtt