liferea icon indicating copy to clipboard operation
liferea copied to clipboard

Extended image format support for Reading Mode

Open Saijin-Naib opened this issue 2 years ago • 8 comments

Right now it seems that sites that host upcoming image formats like webp/avif/heic/heif load placeholder images that can't be viewed in reader mode, though exiting reader mode allows the internal browser to fully-display the content. Are these formats maybe not in the list of filetypes considered "article content"?

Reader Mode for Phoronix:
image

Internal Web-Browser for Phoronix:
image

Liferea View Image:
image

Saijin-Naib avatar Jul 09 '22 10:07 Saijin-Naib

This was actually a base URL problem. You see this in your 3rd screenshot where the image path is broken.

I cannot reproduce this anymore with master. Please retest!

lwindolf avatar Jul 23 '22 15:07 lwindolf

Sorry for the mis-report. I'll retest if I can get it to compile for my distro (or if this fix is in a new tag)

Saijin-Naib avatar Jul 23 '22 16:07 Saijin-Naib

I'm finding that with v1.13.9 and (I guess the base url changes/fixes), that most every article source that used to render mostly correctly, fail to render at all and instead load the full page in the internal Liferea Browser.

Phoronix, as used above, behaves this way now:
image

The error message: Reader Mode Not Possible. Loading URL unfiltered... image

Saijin-Naib avatar Jul 28 '22 01:07 Saijin-Naib

@Saijin-Naib That's strange. I cannot reproduce this regression (tested with Phoronix and the same article you selected).

There was an Readability.js upgrade included in 1.13.9 though...

lwindolf avatar Jul 28 '22 19:07 lwindolf

Reopening the issue because there are still non-rendering images (due to missing base URI) when used with Phoronix website + reader mode. In this case no base URI is set at all anywhere in the rendering output.

So the relative image issue was fixed for item viewing, but not for viewing websites.

lwindolf avatar Jul 28 '22 19:07 lwindolf

@Saijin-Naib That's strange. I cannot reproduce this regression (tested with Phoronix and the same article you selected).

There was an Readability.js upgrade included in 1.13.9 though...

Would my settings for each source impact this? It seems random as some articles in a troublesome feed will work seemingly at random, same for feeds that normally work having failed article loads as well.

Anything I can provide for you to test/reproduce?

Saijin-Naib avatar Jul 28 '22 19:07 Saijin-Naib

@Saijin-Naib Sorry, about taking so long to work on it. No, there is nothing on your side to workaround. It needs to be fixed in the code.

lwindolf avatar Sep 21 '22 17:09 lwindolf

No worries! I appreciate you taking a look at it.

Saijin-Naib avatar Sep 21 '22 17:09 Saijin-Naib

Should be solved now.

lwindolf avatar Sep 23 '22 22:09 lwindolf