rtw89 icon indicating copy to clipboard operation
rtw89 copied to clipboard

debian dkms package don't install correcty

Open theundefined opened this issue 2 years ago • 2 comments

I've successfuly built debian package: dpkg-buildpackage -uc -us -B -rfakeroot and then i've try to install it. It shows:

undefine@undefine-ThinkPad-T470p:~/programowanie/rtw89$ sudo dpkg -i ../rtw89-dkms_1.0.1-1_amd64.deb 
Selecting previously unselected package rtw89-dkms.
(Reading database ... 369152 files and directories currently installed.)
Preparing to unpack .../rtw89-dkms_1.0.1-1_amd64.deb ...
Unpacking rtw89-dkms (1.0.1-1) ...
Setting up rtw89-dkms (1.0.1-1) ...
Building for 5.4.0-80-generic 5.4.0-81-generic
This package appears to be a binaries-only package
 you will not be able to build against kernel 5.4.0-80-generic
 since the package source was not provided
This package appears to be a binaries-only package
 you will not be able to build against kernel 5.4.0-81-generic
 since the package source was not provided

First problem is version - on debian/dkms.conf there is hardcoded version 1.0.0, while package is build with version 1.0.1. After correcting that (to version 1.0.1) i need to manually add that to dkms using:

undefine@undefine-ThinkPad-T470p:~/programowanie/rtw89$ sudo dkms add rtw89/1.0.1     

Creating symlink /var/lib/dkms/rtw89/1.0.1/source ->
                 /usr/src/rtw89-1.0.1

DKMS: add completed.

and then autoinstall that:

undefine@undefine-ThinkPad-T470p:~/programowanie/rtw89$ sudo dkms autoinstall

Kernel preparation unnecessary for this kernel.  Skipping...

Building module:
cleaning build area...
make -j8 KERNELRELEASE=5.4.0-80-generic -C /lib/modules/5.4.0-80-generic/build KBUILD_EXTMOD=/var/lib/dkms/rtw89/1.0.1/build modules.....
Signing module:
 - /var/lib/dkms/rtw89/1.0.1/5.4.0-80-generic/x86_64/module/rtw89pci.ko
 - /var/lib/dkms/rtw89/1.0.1/5.4.0-80-generic/x86_64/module/rtw89core.ko
Secure Boot not enabled on this system.
cleaning build area...

DKMS: build completed.

rtw89pci.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.4.0-80-generic/updates/dkms/

rtw89core.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.4.0-80-generic/updates/dkms/

depmod...

DKMS: install completed.

After that - package works fine. But it's not correct solution :-) Maybe someone have idea how to fix that "right way" to correctly build rtw dkms package for debian/ubuntu? :-)

theundefined avatar Aug 26 '21 10:08 theundefined

i've found that problem is in hardcoded version in post-install debian script. I did na PR to change into current version - but it's not "right way" solution. Maybe it should be replaced during installl?

theundefined avatar Aug 26 '21 10:08 theundefined

https://github.com/lwfinger/rtw89/pull/44

theundefined avatar Aug 26 '21 10:08 theundefined