rtw89 icon indicating copy to clipboard operation
rtw89 copied to clipboard

fix: driver can't resume after S3/S4

Open Zeno-sole opened this issue 3 years ago • 8 comments

Some BIOSs have trouble changing power state from D3hot to D0

Zeno-sole avatar Jul 26 '21 03:07 Zeno-sole

For this problem, we can modify it like this, although it will increase the power consumption a little

Zeno-sole avatar Jul 26 '21 03:07 Zeno-sole

I cannot apply this patch to the repo as it might screw up all the people for which suspend/hibernate work without any problems.

Have you tried the rtw89pci parameters? disable_aspm_l1=y, disable_aspm_l1ss=y. You should try each of them individually, or both. These parameters have solved most problems with buggy BIOSs.

lwfinger avatar Jul 27 '21 01:07 lwfinger

ok, I will try these few parameters

Zeno-sole avatar Jul 27 '21 01:07 Zeno-sole

Have you had a chance to test the module parameters? If yes and they failed, the Realtek engineer thinks we may need a quirk instance for your computer. Please do the following and report the results:

The information I need is manufacturer and product. We can get them by the command: sudo dmidecode | grep "(Manufacturer|Product)"

I heard from my colleague that PCI stack does different thing if .driver.pm is NULL or not, so I'd like to know which case works.

  1. rtw89_pci_suspend/resume do nothing
  2. .driver.pm = NULL

lwfinger avatar Jul 29 '21 19:07 lwfinger

I found the problem on the RTL8822CE network card. When driver.pm = NULL, the S3/S4 process is normal

Zeno-sole avatar Jul 30 '21 02:07 Zeno-sole

That info does not help me. Does adding a return immediately after the entry to rtw89_pci_suspend() and rtw89_pci_resume() work the same as setting driver.pm=NULL?

We also NEED to know the results for the dmidecode statement I gave you earlier.

Without your help, we will not be able to provide a solution that works for everyone.

lwfinger avatar Jul 30 '21 05:07 lwfinger

sudo dmidecode | grep "Manufacturer|Product" Manufacturer: HUAWEI Product Name: NBLL-WXX9 Manufacturer: HUAWEI Product Name: NBLL-WXX9-PCB Manufacturer: HUAWEI Manufacturer: Advanced Micro Devices, Inc. Manufacturer: Samsung Module Manufacturer ID: Bank 1, Hex 0xCE Module Product ID: Unknown Memory Subsystem Controller Manufacturer ID: Unknown Memory Subsystem Controller Product ID: Unknown Manufacturer: Samsung Module Manufacturer ID: Bank 1, Hex 0xCE Module Product ID: Unknown Memory Subsystem Controller Manufacturer ID: Unknown Memory Subsystem Controller Product ID: Unknown

Zeno-sole avatar Jul 30 '21 06:07 Zeno-sole

this HUAWEI Carrying is RTL8822CE,I hace a lenovo xiaoxin carry is rtl8852ae,It is a pity that the graphics card driver problem caused the standby to freeze, Temporarily unable to verify the completed S3/S4 process

Zeno-sole avatar Jul 30 '21 06:07 Zeno-sole