rtl8192du icon indicating copy to clipboard operation
rtl8192du copied to clipboard

Firmware names mismatch

Open mikhailnov opened this issue 1 year ago • 2 comments

There are the following firmware files in this repository:

  • rtl8192dufw.bin
  • rtl8192dufw_wol.bin

But I can't find code which loads this firmware. I see the following code:

include/rtl8192d_hal.h:173:	#define RTL8192D_FW_IMG					"rtl8192DU\\rtl8192dfw.bin"
include/rtl8192c_hal.h:46:	#define RTL8192C_FW_TSMC_IMG				"rtl8192CU\\rtl8192cfwT.bin"
include/rtl8192c_hal.h:47:	#define RTL8192C_FW_UMC_IMG				"rtl8192CU\\rtl8192cfwU.bin"
include/rtl8192c_hal.h:48:	#define RTL8192C_FW_UMC_B_IMG				"rtl8192CU\\rtl8192cfwU_B.bin"
include/rtl8192c_hal.h:50:	#define		RTL8192C_FW_TSMC_WW_IMG			"rtl8192CU\\rtl8192cfwTww.bin"
include/rtl8192c_hal.h:51:	#define		RTL8192C_FW_UMC_WW_IMG			"rtl8192CU\\rtl8192cfwUww.bin"
include/rtl8192c_hal.h:52:	#define		RTL8192C_FW_UMC_B_WW_IMG		"rtl8192CU\\rtl8192cfwU_Bww.bin"
include/rtl8192c_hal.h:78:	#define RTL8723_FW_UMC_IMG				"rtl8723U\\rtl8723fw.bin"

Firmware names are different here.

Maybe this code was copypasted by Realtek from a generic hardware abstraction code that they use for different drivers. But then I do not understand why these firmware files exist in the repository.

mikhailnov avatar Oct 18 '22 13:10 mikhailnov

P.S. I do not have such hardware to somehow test this driver.

mikhailnov avatar Oct 18 '22 13:10 mikhailnov

I think I understood. They embeded the firmware into the code: https://github.com/lwfinger/rtl8192du/blob/83d9f5ae/hal/Hal8192DUHWImg.c#L24 Right?

mikhailnov avatar Oct 18 '22 13:10 mikhailnov