lwansbrough
Plain JS ES6 class works with latest RN
@lwansbrough Updated the component to use plain JS ES6 classes which works with newest versions of react-native
🚀
TOP!
Actually had to change the styling part, as it was not working correctly with this:
this.style = props.style;
Hey @alexanderniebuhr what change did you have to make? Can you paste the code snippet here?
<View style={[styles.background, this.style.backgroundStyle, this.style]}> <Animated.View style={[styles.fill, this.style.fillStyle, { width: fillWidth }]}/>
To
<View style={[styles.background, this.props.backgroundStyle, this.props.style]}> <Animated.View style={[styles.fill, this.props.fillStyle, { width: fillWidth }]}/>
I did change this two lines back to the old ones, so I could use the fillStyle prop as shown in the readme from the module in my main class component :) There might be an other way to set fillStyle, but I want to set it in my class and not in the node_modules folder
@alexanderniebuhr ah ok good catch! I missed that because I was using default stylings, tried to customize it and I see what you mean. Thanks for the heads up!
I'll update the PR 🚀 👍 🌈
No probs. I think there might be, a way with your option, but for me it was the easiest to change it back :)
@alexanderniebuhr ok I made an update, the style override works for me now
You can test it in your project via this if you like 👍
"react-native-progress-bar": "git+https://github.com/phoenixbox/react-native-progress-bar.git#imports-update"
Yeah style works, but then I had to change one thing more:
export default class ProgressBar extends Component {
to
class ProgressBar extends Component {
And adding following line at the end:
module.exports = ProgressBar;
As without I will get following error:
@alexanderniebuhr what did you import look like when you used the version as:
export default class ProgressBar extends Component {}
did it look like this?
import ProgressBar from 'react-native-progress-bar';
I used import from the readme of the initial module
Von meinem iPhone gesendet
Am 02.08.2016 um 10:01 schrieb Shane Rogers [email protected]:
@alexanderniebuhr what did you import look like when you used the version as:
export default class ProgressBar extends Component {} did it look like this?
import ProgressBar from 'react-native-progress-bar'; — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.