lvgl icon indicating copy to clipboard operation
lvgl copied to clipboard

Published 20 hours ago • verified publisher icon lvgl

fix(draw): compile error with color depth 8

Open andresovela opened this issue 3 years ago • 2 comments

Description of the feature or fix

I updated to 8.3 today and I got a compile error because of a non-existent variable. It looks like someone forgot to rename that variable at some point.

Checkpoints

  • [x] Follow the styling guide
  • [x] Run code-format.py from the scripts folder. astyle needs to be installed.
  • [x] Update the documentation

andresovela avatar Jul 07 '22 08:07 andresovela

Looks like the CI did not pick up on this because none of the runners compile with LV_COLOR_SCREEN_TRANSP enabled. It seems that the best option coverage-wise would be to enable it on all of them, since this option adds a lot more code than it disables. @kisvegabor Do you agree?

embeddedt avatar Jul 07 '22 14:07 embeddedt

As we are already in v9-dev phase, I'd refactor lv_conf.h a little bit. As part of it LV_COLOR_SCREEN_TRANSP should be removed as due to the new layering features it should be always enabled. What do you think?

kisvegabor avatar Jul 07 '22 19:07 kisvegabor

We need some feedback on this pull request.

Now we mark this as "stale" because there was no activity here for 14 days.

Remove the "stale" label or comment else this will be closed in 7 days.

lvgl-bot avatar Sep 01 '22 02:09 lvgl-bot