lv_binding_js icon indicating copy to clipboard operation
lv_binding_js copied to clipboard

fix: rename file to fix compilation errors

Open Gary-Hobson opened this issue 2 years ago • 6 comments

I failed to compile with master branch on ubuntu 20.04 (X86-64)

It seems to be caused by some letter case differences

Gary-Hobson avatar Oct 26 '22 18:10 Gary-Hobson

cc @Sxs7513

kisvegabor avatar Oct 29 '22 09:10 kisvegabor

same as:

diff --git a/src/render/native/components/calendar/calendar_wrap.cpp b/src/render/native/components/calendar/calendar_wrap.cpp index 1177525..e8283cb 100644 --- a/src/render/native/components/calendar/calendar_wrap.cpp +++ b/src/render/native/components/calendar/calendar_wrap.cpp @@ -1,4 +1,4 @@ -#include "Calendar.hpp" +#include "calendar.hpp"

static JSClassID CalendarClassID;

diff --git a/src/render/native/components/gif/gif_wrap.cpp b/src/render/native/components/gif/gif_wrap.cpp index ee920ba..1f44e90 100644 --- a/src/render/native/components/gif/gif_wrap.cpp +++ b/src/render/native/components/gif/gif_wrap.cpp @@ -1,4 +1,4 @@ -#include "GIF.hpp" +#include "gif.hpp"

static JSClassID GIFClassID;

diff --git a/src/render/native/components/mask/mask_wrap.cpp b/src/render/native/components/mask/mask_wrap.cpp index 5d7ccd8..36cd726 100644 --- a/src/render/native/components/mask/mask_wrap.cpp +++ b/src/render/native/components/mask/mask_wrap.cpp @@ -1,4 +1,4 @@ -#include "Mask.hpp" +#include "mask.hpp"

static JSClassID MaskClassID;

zdzDesigner avatar Jul 06 '23 07:07 zdzDesigner

Hi!

@Gary-Hobson @zdzDesigner @kisvegabor @haigithub

Is this one not merged? What is the workaround then? We hit the same issue.

svits-llc avatar Aug 04 '23 20:08 svits-llc

@kisvegabor This PR has not received a reply for too long. I thought no one maintained this repository, so I closed it.

Fortunately it seems to be active now, but the problem still exists

Gary-Hobson avatar Oct 09 '23 09:10 Gary-Hobson

Hey,

Actually, @derekstavis is maintaining this repository now. Derek, could you take look as this pull request?

kisvegabor avatar Oct 10 '23 20:10 kisvegabor

I'll look into this in the next few days. I didn't have notifications enabled in the repo and missed all the updates :sweat_smile:

derekstavis avatar Nov 15 '23 14:11 derekstavis

Please let me know if this is still a problem in the latest main

derekstavis avatar Aug 05 '24 01:08 derekstavis