abi-compliance-checker icon indicating copy to clipboard operation
abi-compliance-checker copied to clipboard

Circular dependencies

Open Holo-Viktor opened this issue 5 years ago • 1 comments

according to the readmes ABICC requires ABI dumper and ABI dumper requires ABICC

Holo-Viktor avatar Sep 16 '19 13:09 Holo-Viktor

It looks like there is a simple mistake in the documentation for abi-dumper, and there is no actual circular dependency.

abi-dumper/README.md says this:

Requires
...
ABI Compliance Checker >= 2.2 (https://github.com/lvc/abi-compliance-checker)

However, no such dependency is listed in abi-dumper/INSTALL.

I did not check the code in detail, but this makes sense in this code architecture. If developer agrees, would you please remove this dependency line for ABI Compliance Checker in abi-dumper/README.md. Thank you.

Dave-Allured avatar Dec 24 '19 07:12 Dave-Allured