abi-compliance-checker icon indicating copy to clipboard operation
abi-compliance-checker copied to clipboard

More consistent handling and logging of shell command output

Open dkogan opened this issue 8 years ago • 2 comments

This is a possible solution to #45. system() was replaced with a function that invokes the shell with IPC::Run::run(), This captures the output, puts it in the appropriate place, and logs it if($Debug). We probably want to do something more intelligent than sending stuff to .../null, and with this new infrastructure, we can.

dkogan avatar Jul 31 '16 04:07 dkogan

Hello,

Thank you for the patch. But we are trying to use Perl Core modules only (http://perldoc.perl.org/index-modules-I.html) to improve portability and minimize dependencies of the tool. Is it possible to avoid using IPC::Run?

Thank you.

lvc avatar Aug 02 '16 13:08 lvc

lvc [email protected] writes:

Thank you for the patch. But we are trying to use Perl Core modules only (http://perldoc.perl.org/index-modules-I.html) to improve portability and minimize dependencies of the tool. Is it possible to avoid using IPC::Run?

No. IPC::Run exists to fill in functionality gaps in the core. I really think you should reconsider this policy. Linux distributions all have dependency resolution figured out, and setting your policy based on something like osx is just weird.

dkogan avatar Aug 03 '16 05:08 dkogan