depthai-python icon indicating copy to clipboard operation
depthai-python copied to clipboard

Improved `poe_set_ip.py` script usage and reduced chance of errors.

Open ahrastnik opened this issue 10 months ago • 3 comments

Improves the poe_set_ip.py example.

  • Added input validation
  • Added command for getting the currently set IP in order to verify it
  • Made it so the command can be run in one step, so it's easier to set multiple devices

ahrastnik avatar Apr 19 '24 11:04 ahrastnik

@Erol444 please review & merge if okay

themarpe avatar May 14 '24 11:05 themarpe

@ahrastnik Could we also update the docs for this example? https://github.com/luxonis/depthai-python/blob/main/docs/source/samples/bootloader/poe_set_ip.rst Just on how to use the script/args Otherwise LGTM, works as expected

Erol444 avatar May 14 '24 12:05 Erol444

@Erol444 done. I've also noticed there's a C++ version of the script. It would be best to get someone to update that too for the sake for completeness.

ahrastnik avatar May 15 '24 19:05 ahrastnik