depthai-core icon indicating copy to clipboard operation
depthai-core copied to clipboard

Added queue.getFps() function and tests for this function

Open Erol444 opened this issue 10 months ago • 4 comments

Works (as expected). I consulted o3-mini-high and they approved it already.

% ./message_queue_test
Randomness seeded to: 2163801883
===============================================================================
All tests passed (63 assertions in 18 test cases)

Erol444 avatar Feb 01 '25 11:02 Erol444

The test didn't fail before, I think this introduces a race condition in the code.

moratom avatar Feb 03 '25 11:02 moratom

How about getMessagesPerSecond instead getFPS?

SzabolcsGergely avatar Feb 04 '25 16:02 SzabolcsGergely

@SzabolcsGergely while it's more accurate, I think most people are used to FPS, even if it's actually Inference per second / Messages per second. Pehraps we could go with getQueueHz(), which is also quite widely used (aka hz == fps)?

Erol444 avatar Feb 05 '25 16:02 Erol444

@SzabolcsGergely while it's more accurate, I think most people are used to FPS, even if it's actually Inference per second / Messages per second. Pehraps we could go with getQueueHz(), which is also quite widely used (aka hz == fps)?

I don't see getQueueHz fit/good choice, personally. This measurement refers to queue message rate per second.

SzabolcsGergely avatar Feb 05 '25 17:02 SzabolcsGergely