depthai-core icon indicating copy to clipboard operation
depthai-core copied to clipboard

Update to use latest xlink repo and added Clang support

Open onthegrid007 opened this issue 1 year ago • 6 comments

Update to use latest xlink repo and added Clang support

onthegrid007 avatar Aug 11 '24 05:08 onthegrid007

Thanks @onthegrid007 - any particular reason for the switch to ninja?

moratom avatar Aug 12 '24 10:08 moratom

CI fails on MacOS: https://github.com/luxonis/depthai-core/actions/runs/10337442673/job/28646392973

Let's either leave the CI builders as is or extend with a "matrix" to build with both GCC and Clang.

moratom avatar Aug 12 '24 10:08 moratom

Thanks @onthegrid007 - any particular reason for the switch to ninja?

Ninja is required for Clang on windows to overwrite the use of MSVS compiler in Cmake...

Thought it would be easier overall if everything just switched over at once.

onthegrid007 avatar Aug 12 '24 14:08 onthegrid007

Unfortunately unless I rebuild opencv in the ci I have to use clang with a target for mingw and mingw be the library target on windows, Ninja is still required for it not to default to MSVS, and since it's only a single binary for installation I'm not too worried...

Question, @moratom should I rebuild opencv cleanly in the ci so clang can work without mingw (see windows latest build for the error I'm mentioning) or is there a way like it kind of mentions to just specify opencv_dir and hope there's no binary discrepancies between the mingw prebuilt opencv binaries and clang compiling with msvs as the target libraries?

onthegrid007 avatar Aug 14 '24 22:08 onthegrid007

@onthegrid007 we don't necessarily want to switch the CI to clang, rather we should extend it, so we run both with GCC and clang in the CI.

You can use the "matrix" for that in github actions.

Note that we'll be mainlining the updated XLink in this PR https://github.com/luxonis/depthai-core/pull/1098 and keep the this one to expend the CI to clang.

moratom avatar Aug 18 '24 13:08 moratom

Is this good enough?

onthegrid007 avatar Sep 20 '24 02:09 onthegrid007