sinuous icon indicating copy to clipboard operation
sinuous copied to clipboard

sinuous/map v0.30.0 removes node unexpectedly.

Open j-sen opened this issue 2 years ago • 1 comments

When [ "foo", "BAR", "baz" ] is transformed to [ "BAR" ], all elements will be deleted then "BAR" will be recreated.

In version 0.27.6, [ "foo", "BAR", "baz" ] is transformed to [ "BAR" ] by deleting "foo" and "baz", which seems more reasonable.

Here is the code demonstrates this situation. https://codepen.io/j-sen/pen/MWzdBdP

j-sen avatar Aug 10 '23 03:08 j-sen

@luwes remember that infinite thread where I tested every single one of those reconcilers? as I recall, this one did have a problem like this. maybe it's time to replace it?

@j-sen you could look around (try a search for "reconciler" in issues) and see if you can find that very long thread of mine - I tested and benchmarked every algo and found several of them to have problems... as I recall, there was a pretty clear cut winner in terms of file size, performance and correctness, and it wasn't the one being used here.

as I recall @luwes was open to replacing it - and it should be fairly easy to drop in the replacement, but he's also said the project is low priority for him. It seems he's still accepting pull requests though. 🙂

mindplay-dk avatar Nov 08 '23 10:11 mindplay-dk