sinuous icon indicating copy to clipboard operation
sinuous copied to clipboard

Add exports for Node ESM resolution

Open davidmyersdev opened this issue 3 years ago • 1 comments

Some bundlers can't resolve the correct ESM imports for sinuous due to the lack of a "type": "module" definition along with "exports" definitions for each package. Specifically, this will allow sinuous to work with vitest.

Check out this explanation on dual packaging for more info.

davidmyersdev avatar May 08 '22 03:05 davidmyersdev

Codecov Report

Merging #201 (4997b1a) into main (c7beffd) will increase coverage by 99.67%. The diff coverage is n/a.

@@            Coverage Diff            @@
##           main     #201       +/-   ##
=========================================
+ Coverage      0   99.67%   +99.67%     
=========================================
  Files         0       18       +18     
  Lines         0      609      +609     
=========================================
+ Hits          0      607      +607     
- Misses        0        2        +2     
Impacted Files Coverage Δ
packages/sinuous/render/src/render.js 100.00% <0.00%> (ø)
packages/sinuous/h/src/property.js 100.00% <0.00%> (ø)
packages/sinuous/h/src/remove-nodes.js 100.00% <0.00%> (ø)
packages/sinuous/h/src/add.js 100.00% <0.00%> (ø)
packages/sinuous/h/src/api.js 100.00% <0.00%> (ø)
packages/sinuous/data/src/data.js 100.00% <0.00%> (ø)
packages/sinuous/hydrate/src/index.js 100.00% <0.00%> (ø)
packages/sinuous/hydrate/src/hydrate.js 100.00% <0.00%> (ø)
packages/sinuous/template/src/template.js 100.00% <0.00%> (ø)
packages/sinuous/observable/src/observable.js 100.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c7beffd...4997b1a. Read the comment docs.

codecov[bot] avatar May 08 '22 03:05 codecov[bot]

"type": "module" I had to revert because it was causing issues with the site build. hope it still works with the exports

luwes avatar Sep 04 '22 01:09 luwes