lit icon indicating copy to clipboard operation
lit copied to clipboard

coro-net optionalDependencies metadata?

Open squeek502 opened this issue 9 years ago • 3 comments
trafficstars

coro-net defines an optionalDependencies key in its metadata, but as far as I can tell that is unsupported by lit. Was this something that there were plans to add support for?

squeek502 avatar Jun 24 '16 01:06 squeek502

It was an idea. I"m not sure how it would work exactly.

Do you have any ideas how it should work?

creationix avatar Jun 24 '16 16:06 creationix

I guess optional dependencies would be something that could be prompted for during lit install but prompting doesn't seem ideal. Could instead warn during lit install of a package with optionalDependencies and give instructions for how to install the optional ones.

Might also want to throw a more descriptive runtime error like To use tls, 'secure-socket' must be installed. Run 'lit install luvit/[email protected]'

However, it seems like coro-net might not be a good use case for optionalDependencies, as tls seems like something worth supporting generally.

squeek502 avatar Jun 24 '16 17:06 squeek502

The thing with secure-socket is it depends on openssl which not all luvi builds have. And in many cases, luvi might be used for a web server that sits behind a ssl terminating proxy and not need tls itself.

creationix avatar Jun 24 '16 17:06 creationix