luukvbaal
luukvbaal
@WillEhrendreich if you can reproduce reliably, checking if #28961 resolves it could help :)
TBH I don't think I was finished working on this and forgot this was even part of #28101 when I quickly reworked it to be included as experimental. Probably our...
`number_width()`'s cached value is incorrect in this repro. Here's one way to fix the crash by making sure the numberwidth cache is invalidated(there might be a better way): ```diff @@...
ASAN crash only reproduces with `--clean` and `-c`, not when exchanging either of those with e.g. `-u NONE` and `--cmd`. I guess that further suggests that this is just a...
Good to know, I can try to add a different test in that case.
OK yeah I was just misled by the involved repro in the linked issue. Exchanged for a simpler test that crashes on master with an ASAN build.
> ### Vim (not Nvim) behaves the same? > > No (doesn't have this functionality) Not true, `number_hl_group` just implements the legacy sign `numhl` property. FWIW, vim behaves the same,...
To the contrary, extmark signs and legacy signs use the same drawing code path and are functionally identical. The same "issue" can be reproduced in both vim and nvim with...
I mean yeah but it's a relevant implementation detail. I don't think it makes sense to consider the extmark case in isolation.
The `:h sign-define` docs specifically state that `numhl` overrides the `*LineNr*` hl groups BTW.