saka-key
saka-key copied to clipboard
lusakasa
Remove "tabs" permission
Hey,
This PR removes the tabs permission and refactors/removes anything that depended on tab.url or tab.title.
The only real change is that I removed the "duplicate in incognito" command.
There's perhaps a way to support this command without relying on tab.url but I really couldn't think of one.
I'm still not 100% sure why Chrome are kicking off about what seems to be a pretty legitimate justification for requesting the "tabs" permission, but since they've nuked it from all the stores as a result it seems more pragmatic to get the permission removed for now.
If someone is in a position to query Google as to why they object to the permission being requested we can always revert parts of this PR and bring back the removed command.
Anyway, hope this is all ok. I've not had a chance to test v thoroughly because i'm at work
@ceuk I created a PR for your branch which removes this await.
https://github.com/ceuk/saka-key/pull/1
If you accept it, I believe it will show up here too.
@pureooze, are there any further actions we need to take to get this PR merged? s there any further actions we need to take to get this PR merged?
@eejdoowad and @neilmacintyre, I see you are both maintainers of lusakasa. Would either of you be willing to help us get this PR merged?
This PR fixes: Chrome Store Extension Not Found #311
I'd love to see saka-key back in the chrome web store. :yellow_heart:
Me too. Can @lusakasa comment on what they think happened with the extension, and merge this?
@pureooze
Could you help us push this PR through? You mentioned that if someone took on the work, then you could help push it through to the respective stores.
https://github.com/lusakasa/saka-key/issues/331#issuecomment-899839440