saka-key icon indicating copy to clipboard operation
saka-key copied to clipboard

Presence of Saka client (a`div` element added to every page) breaks at least one website

Open amn opened this issue 6 years ago • 6 comments

I am aware some [techincally] related issues have been filed, like #192, #42, #170, #165, etc.

I am also aware the project needs a maintainer and this issue may not get any attention. This is for posterity.

Perhaps adding a div element ahead of the body element on each page, isn't a very good solution. Too early for me to tell, before I understand the architecture of the extension and necessities of what it does.

However, it is entirely expected that such an approach would break websites:

  • Some sites apply CSS very liberally, for instance using rules like div { /* ... */ } which also affects the Saka Key client (the aforementioned inserted div), usually in an undesirable manner. We could argue that everyone should use body > div to be on the right site of valid markup border, but then again, div element outside body element is invalid too.
  • Some sites apply scripts liberally, in similar sense to above -- the presence of the Saka Key client either breaks the script(s) completely or results again in undesirable behavior noticed by user.

Perhaps a non-HTML ("foreign element" is the term I believe) element instead of a div would be better suited for the client? Optionally, with own XML namespace for XML/XHTML documents.

Even better, can Saka Key be made to work entirely without said client element? No element at all is ideal, but I can't tell if every feature can work without one.

amn avatar May 27 '18 12:05 amn

We need a blacklist feature.

lonix1 avatar Jul 06 '18 09:07 lonix1

+1. Another example: https://personal.vanguard.com/us/faces/com/vanguard/logon/view/LogonLogoff.xhtml

bubbagump210 avatar Feb 23 '19 19:02 bubbagump210

Same here: http://goodtemperapps.com/ Blacklisting this domain doesn't work.

MaxGyver83 avatar Jul 06 '19 08:07 MaxGyver83

It looks like that even blacklisting a website won't prevent Saka Key from adding the div element to the page. Fixing this would probably work as a workaround to fix any site broken by Saka.

Macellatore avatar Jul 15 '19 13:07 Macellatore

It also breaks built-in Firefox xml viewer.

broiniac avatar Jul 01 '20 10:07 broiniac