saka-key
saka-key copied to clipboard
Presence of Saka client (a`div` element added to every page) breaks at least one website
I am aware some [techincally] related issues have been filed, like #192, #42, #170, #165, etc.
I am also aware the project needs a maintainer and this issue may not get any attention. This is for posterity.
Perhaps adding a div
element ahead of the body
element on each page, isn't a very good solution. Too early for me to tell, before I understand the architecture of the extension and necessities of what it does.
However, it is entirely expected that such an approach would break websites:
- Some sites apply CSS very liberally, for instance using rules like
div { /* ... */ }
which also affects the Saka Key client (the aforementioned inserteddiv
), usually in an undesirable manner. We could argue that everyone should usebody > div
to be on the right site of valid markup border, but then again,div
element outsidebody
element is invalid too. - Some sites apply scripts liberally, in similar sense to above -- the presence of the Saka Key client either breaks the script(s) completely or results again in undesirable behavior noticed by user.
Perhaps a non-HTML ("foreign element" is the term I believe) element instead of a div
would be better suited for the client? Optionally, with own XML namespace for XML/XHTML documents.
Even better, can Saka Key be made to work entirely without said client element? No element at all is ideal, but I can't tell if every feature can work without one.
We need a blacklist feature.
+1. Another example: https://personal.vanguard.com/us/faces/com/vanguard/logon/view/LogonLogoff.xhtml
Same here: http://goodtemperapps.com/ Blacklisting this domain doesn't work.
It looks like that even blacklisting a website won't prevent Saka Key from adding the div element to the page. Fixing this would probably work as a workaround to fix any site broken by Saka.
It also breaks built-in Firefox xml viewer.