saka-key icon indicating copy to clipboard operation
saka-key copied to clipboard

Back loses position on previous page.

Open freiform opened this issue 6 years ago • 10 comments

May be related to https://github.com/lusakasa/saka-key/issues/166.

When following a link and going back to the previous page (shortcut or back-button), I start at the top of the page. The previous position is lost. If I disable the addon, it works again as intended.

Can be reproduced on multiple systems, amongst them:

  • Firefox 58.0.2
  • Saka Key 1.25.2
  • Debian 9

freiform avatar Mar 01 '18 09:03 freiform

This is an issue for me as well.

  • Firefox 58.0.2
  • Saka Key 1.25.2
  • Fedora 27 (Workstation)

It doesn't seem to matter what method is used to go back. I can use a key bound by saka key, or the browser back button. They all have the same result unless saka key is disabled.

kevenwyld avatar Mar 01 '18 15:03 kevenwyld

I have the problem too, but I would like to add that I AM PRETTY SURE this is a new (like 5 weeks). However, I went to Saka Key 1.25.2 back in November 2017. Are we sure it's not FF 58? I'm guessing FF58 changed and caused this behavior. Just a guess.

Just tested at FF57. No problem. But, yes, SakaKey needs to address this

joefiesta avatar Mar 01 '18 15:03 joefiesta

Either way, the addon must account for this change.

freiform avatar Mar 01 '18 15:03 freiform

@joefiesta I just tested with Firefox 57.0.4 and you are correct it is not an issue in that version. However even though Firefox changed shouldn't this remain open?

kevenwyld avatar Mar 01 '18 15:03 kevenwyld

My bad.. I certainly did not mean to close the issue. I thought close and comment would close this page or something.... duh....

yes, now how do I reopen it?

joefiesta avatar Mar 01 '18 16:03 joefiesta

nevermind... figure out how to and REOPENED this issue. Sorry....

joefiesta avatar Mar 01 '18 16:03 joefiesta

Would like to vouch for this behaviour as well. Using FF 59 under Linux. Very good add-on, I can tap whichever key I want and close, duplicate, restore tabs, it's very handy, just some positive mentions...

addeps3 avatar Mar 24 '18 13:03 addeps3

Another issue for the same problem: https://github.com/lusakasa/saka-key/issues/193

freiform avatar Oct 01 '18 09:10 freiform

Just FYI if you closes the tab and re-open it with shift-t, the scroll position restores as expected. I'm using FF 66.0.2 here and experiencing the same problem.

KentVu avatar Apr 17 '19 05:04 KentVu

This problem is currently fixed in the master branch (tested on Firefox 74.0).

migueldvb avatar Apr 05 '20 21:04 migueldvb