lurk-rs icon indicating copy to clipboard operation
lurk-rs copied to clipboard

Additional bit of precision lost with curve change

Open cpacia opened this issue 1 year ago • 1 comments
trafficstars

With the change in curves the pack_bits gadget is now dropping the first three bits instead of just the first two as was the case with the prior curves.

This affects the sha256 coprocessor. It's just a one liner change, I can submit a PR if you want but I don't know if there are other areas of lurk that might be affected by this.

cpacia avatar Feb 13 '24 23:02 cpacia

Sure, you can go for the minimal PR and then we evaluate the need of subsequent PRs afterwards.

Thanks for opening the issue!

arthurpaulino avatar Feb 14 '24 11:02 arthurpaulino